Update es-es.json #9
Conversation
Udpated to v1.3.5
WalkthroughSpanish localization file updated: metadata header keys replaced, several strings revised, and new configuration keys added. Removed legacy comment keys; added version/credits headers. Introduced translations for urine particle lifetime and bladder enable settings; adjusted wording for bladder fill multiplier, hotkey-only pee, cave art stain labels, and sit/peemode. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks (2 passed, 1 inconclusive)❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
NaturesCall/assets/naturescall/lang/es-es.json (2)
2-3: Trim trailing spaces and avoid publishing header comments as translatable keysBoth header keys end with a trailing space, which creates awkward, easy-to-miss keys. Also consider keeping such metadata out of the translation namespace (e.g., switch to a single
_commentkey or remove entirely).Apply minimal fix (trim trailing spaces):
- "// Nature's Call v1.3.5 || Enlace de VS ModDB: https://mods.vintagestory.at/naturescall ": "", - "// Traducido por C4BR3R4 || Última Modificación: 10/09/2025 || Registro de Cambios: https://c4br3r4.es/index.php?topic=1328.0 ": "", + "// Nature's Call v1.3.5 || Enlace de VS ModDB: https://mods.vintagestory.at/naturescall": "", + "// Traducido por C4BR3R4 || Última Modificación: 10/09/2025 || Registro de Cambios: https://c4br3r4.es/index.php?topic=1328.0": "",
57-57: Remove placeholder key from production locale“// Inexistente en la v1.3.2 ” (note trailing space) is a maintenance placeholder and should not ship.
- "// Inexistente en la v1.3.2 ": "",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
NaturesCall/assets/naturescall/lang/es-es.json(3 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
NaturesCall/assets/naturescall/lang/es-es.json (3)
NaturesCall/Util/Constants.cs (1)
Constants(7-58)NaturesCall/Config/ConfigLibCompat.cs (1)
ConfigLibCompat(12-87)NaturesCall/Hud/BladderBarHudElement.cs (1)
NaturesCall(9-137)
🔇 Additional comments (3)
NaturesCall/assets/naturescall/lang/es-es.json (3)
35-36: Compat heading tweak LGTMWording is clearer and matches the compat intent.
45-45: Verify intended in-game label for cave-art stainChanging “Mancha de Orina” to just “Orina” may lose context for a stain block. Please confirm in-game UI lists this among cave-art stains; if clarity suffers, consider “Pintura Rupestre: Orina” or keep “Mancha de Orina”.
58-58: Confirm this setting exists in code“Config.Setting.EnableBladder” isn’t visible in the provided config builders. Please verify it’s referenced by ConfigLib or server/client configs; otherwise it’s dead text.
| "naturescall": "Nature's Call", | ||
|
|
||
| "Config.Setting.BladderFillMultiplier": "Multiplicador de llenado de la Vejiga", | ||
| "Config.Setting.BladderFillMultiplier": "Volumen de Llenado de la Vejiga", |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Preserve “multiplier” semantics; “Volumen” is misleading
The setting controls a multiplier, not an absolute volume. Recommend reverting to a “multiplicador” phrasing.
-"Config.Setting.BladderFillMultiplier": "Volumen de Llenado de la Vejiga",
+"Config.Setting.BladderFillMultiplier": "Multiplicador de Llenado de la Vejiga",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Config.Setting.BladderFillMultiplier": "Volumen de Llenado de la Vejiga", | |
| "Config.Setting.BladderFillMultiplier": "Multiplicador de Llenado de la Vejiga", |
🤖 Prompt for AI Agents
In NaturesCall/assets/naturescall/lang/es-es.json around line 11, the
translation uses "Volumen de Llenado de la Vejiga" which implies an absolute
volume; change the string to preserve multiplier semantics by using
"Multiplicador de Llenado de la Vejiga" (or "Multiplicador de nivel de llenado
de la vejiga") so it clearly indicates a multiplier setting.
| "Config.Setting.UrineColor": "Color de la Orina", | ||
| "Config.Setting.OnlyPeeWithHotkey": "Orinar solo al presionar la tecla rápida (no clic derecho)", | ||
| "Config.Setting.OnlyPeeWithHotkey": "Orinar solo al pulsar la Tecla Asignada (sin usar el Botón Derecho).", | ||
| "Config.Setting.UrineParticleLifetime": "Vida útil de las Partículas de Orina (solo funciona si está desactivada en el servidor las «Manchas de Orina»).", |
There was a problem hiding this comment.
Grammar agreement fix (“están desactivadas”)
Subject is plural (“las «Manchas de Orina»”).
-"Config.Setting.UrineParticleLifetime": "Vida útil de las Partículas de Orina (solo funciona si está desactivada en el servidor las «Manchas de Orina»).",
+"Config.Setting.UrineParticleLifetime": "Vida útil de las Partículas de Orina (solo funciona si están desactivadas en el servidor las «Manchas de Orina»).",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Config.Setting.UrineParticleLifetime": "Vida útil de las Partículas de Orina (solo funciona si está desactivada en el servidor las «Manchas de Orina»).", | |
| "Config.Setting.UrineParticleLifetime": "Vida útil de las Partículas de Orina (solo funciona si están desactivadas en el servidor las «Manchas de Orina»).", |
🤖 Prompt for AI Agents
NaturesCall/assets/naturescall/lang/es-es.json around line 33: the
adjective/verb agreement is wrong in the phrase "solo funciona si está
desactivada en el servidor las «Manchas de Orina»"; change it to use plural
agreement to match the plural subject, e.g. "solo funciona si están desactivadas
en el servidor las «Manchas de Orina»" (ensure quotes and punctuation remain
consistent with the surrounding JSON entry).
| "hud-choosepeemode": "El Modo de Micción no está configurado. Por favor, elije:", | ||
| "peemode-stand": "De Pie", | ||
| "peemode-sit": "Sentado" | ||
| "peemode-sit": "Agachado", |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Align “Agachado” with the prompt and fix typos in nearby strings
You switched the option to “Agachado” but the question still says “Sentado”, and there are a couple of typos. Suggest aligning the prompt and fixing accents.
Outside this hunk, apply:
-"Config.Setting.PeeMode": "¿Orinas de Pie o Sentado?",
+"Config.Setting.PeeMode": "¿Orinas de Pie o Agachado?",
-"hud-choosepeemode": "El Modo de Micción no está configurado. Por favor, elije:",
+"hud-choosepeemode": "El Modo de Micción no está configurado. Por favor, elige:",
-"peemodenotset": "Necesitas configurar si Orinas de Pié o Sentado. Usa <hk>configlibconfigs</hk> para configurarlo.",
+"peemodenotset": "Necesitas configurar si orinas de Pie o Agachado. Usa <hk>configlibconfigs</hk> para configurarlo.",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "peemode-sit": "Agachado", | |
| "Config.Setting.PeeMode": "¿Orinas de Pie o Agachado?", | |
| "hud-choosepeemode": "El Modo de Micción no está configurado. Por favor, elige:", | |
| "peemodenotset": "Necesitas configurar si orinas de Pie o Agachado. Usa <hk>configlibconfigs</hk> para configurarlo.", | |
| "peemode-sit": "Agachado", |
1 participant
Udpated to v1.3.5
Summary by CodeRabbit